fix(compiler-cli): only use error collector when needed. #19912
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error collector changes behavior of the metadata resolver
in ways that haven't been fully hardened. This changes limits
its use to the lazy route detection and the language service.
Issue: #19906
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #19906
Part of issue 19906 demonstrates that the compiler was loosing error messages.
What is the new behavior?
Reverted the error collector for use in the primary
ngc
code path, switching back to a single error reporting mechanism used prior to the change.The multiple error reporting is deferred now till 5.1 which will allow us time to harden the compiler against the changes to the metadata collector implied by using the error collector.
Does this PR introduce a breaking change?